Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat example #9

Merged
merged 16 commits into from
Apr 1, 2021
Merged

chat example #9

merged 16 commits into from
Apr 1, 2021

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Mar 24, 2021 •
edited
Loading

Resolves #15

@D4nte D4nte changed the title Test connection triggered from js and add API chat example Mar 24, 2021
@D4nte D4nte marked this pull request as ready for review March 26, 2021 00:48
This was referenced Mar 28, 2021
Closed
Closed
@D4nte D4nte force-pushed the chat-app branch 2 times, most recently from 3b5b203 to b901308 Compare March 30, 2021 01:01
@D4nte
Copy link
Contributor Author

D4nte commented Mar 31, 2021

bors try

bors bot added a commit that referenced this pull request Mar 31, 2021
@bors
Try #9:
8e30893
D4nte added 11 commits April 1, 2021 11:01
@D4nte
Chat app example
f2c1c92
@D4nte
Remove StrictSign hack
0866232
@D4nte
Include js>nim>js test
2b450cf
@D4nte
Can receive message over internet
d2f1995
@D4nte
Pass listening addresses as argument
c3cf646
@D4nte
Get peer connection details from command line
b4e5d6d
@D4nte
Seem to fix receiving messages
d9decab 
Looking at runs where receiving messages work vs doesn't, in the case it
 does not work, js-chat is still receiving some messages as part
 of the identify process after subscribing.
 Whereas, when it works, the subscribe is done after those messages.
 With a 2s sleep to delay the subscribe, it seems that it always works.
@D4nte
Move chat folder inside src
0b282be
@D4nte
Correct package name
0f694cf
@D4nte
Implement chat message protobuf to support nick and time handles
cca1d68
@D4nte
Custom nick
58838ec
@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

try

Build succeeded:

D4nte added 3 commits April 1, 2021 11:15
@D4nte
Reference GitHub issues
f15f4ff
@D4nte
Update readme to include chat app
861bc2d
@D4nte
Avoid possible type name clash between js-waku and consuming apps
5a967ec 
`Message` is a very generic name and JS does not offer strong namespace
boundaries. Using `WakuMessage` avoid name clashing with classes
of the consumer app.
@D4nte
Copy link
Contributor Author

D4nte commented Apr 1, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

Build succeeded:

@bors bors bot merged commit 62b27fd into main Apr 1, 2021
@bors bors bot deleted the chat-app branch April 1, 2021 03:15
fryorcraken added a commit that referenced this pull request Nov 10, 2022
@fryorcraken
test: use bytes in payload instead of utf-8 to better track messages
dde6555 
in logs. Also check presence of message #9 which is the one missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waku relay (node): chat app example
1 participant
@D4nte