chore: Updating nim-chronicles, nim-chronos, nim-presto, nimcrypto, n…

…im-libp2p, and nim-nat-transversal (#2043)
waku-org · Sep 18, 2023 · f617cd9 · f617cd9
1 parent 72f9066
commit f617cd9
Show file tree

Hide file tree

Showing 11 changed files with 37 additions and 35 deletions.
diff --git a/vendor/nim-chronicles b/vendor/nim-chronicles
diff --git a/vendor/nim-chronos b/vendor/nim-chronos
diff --git a/vendor/nim-libp2p b/vendor/nim-libp2p
diff --git a/vendor/nim-nat-traversal b/vendor/nim-nat-traversal
diff --git a/vendor/nim-presto b/vendor/nim-presto
diff --git a/vendor/nimcrypto b/vendor/nimcrypto
diff --git a/waku/node/rest/store/handlers.nim b/waku/node/rest/store/handlers.nim
@@ -7,6 +7,7 @@ import
   std/strformat,
   stew/results,
   chronicles,
+  uri,
   json_serialization,
   presto/route
 import

diff --git a/waku/node/waku_metrics.nim b/waku/node/waku_metrics.nim
@@ -21,21 +21,17 @@ const LogInterval = 30.seconds
 logScope:
   topics = "waku node metrics"
 
-
-type
-  # https://github.com/nim-lang/Nim/issues/17369
-  MetricsLogger = proc(udata: pointer) {.gcsafe, raises: [Defect].}
-
 proc startMetricsLog*() =
-  var logMetrics: MetricsLogger
+  var logMetrics: CallbackFunc
 
   var cumulativeErrors = 0.float64
   var cumulativeConns = 0.float64
 
   let logRlnMetrics = getRlnMetricsLogger()
 
-  logMetrics = proc(udata: pointer) =
-    {.gcsafe.}:
+  logMetrics = CallbackFunc(
+    proc(udata: pointer) {.gcsafe.} =
+
       # TODO: libp2p_pubsub_peers is not public, so we need to make this either
       # public in libp2p or do our own peer counting after all.
 
@@ -62,6 +58,7 @@ proc startMetricsLog*() =
       # Start protocol specific metrics logging
       logRlnMetrics()
 
-    discard setTimer(Moment.fromNow(LogInterval), logMetrics)
+      discard setTimer(Moment.fromNow(LogInterval), logMetrics)
+  )
 
   discard setTimer(Moment.fromNow(LogInterval), logMetrics)
diff --git a/waku/node/waku_node.nim b/waku/node/waku_node.nim
@@ -114,14 +114,14 @@ proc getAutonatService*(rng: ref HmacDrbgContext): AutonatService =
   let autonatService = AutonatService.new(
     autonatClient = AutonatClient.new(),
     rng = rng,
-    scheduleInterval = Opt.some(chronos.seconds(120)),
+    scheduleInterval = some(chronos.seconds(120)),
     askNewConnectedPeers = false,
     numPeersToAsk = 3,
     maxQueueSize = 3,
     minConfidence = 0.7)
 
   proc statusAndConfidenceHandler(networkReachability: NetworkReachability,
-                                  confidence: Opt[float]):
+                                  confidence: Option[float]):
                                   Future[void]  {.gcsafe, async.} =
     if confidence.isSome():
       info "Peer reachability status", networkReachability=networkReachability, confidence=confidence.get()

diff --git a/waku/waku_archive/archive.nim b/waku/waku_archive/archive.nim
@@ -221,19 +221,21 @@ proc startMessageRetentionPolicyPeriodicTask*(w: WakuArchive,
   # Start the periodic message retention policy task
   # https://github.com/nim-lang/Nim/issues/17369
 
-  var executeRetentionPolicy: proc(udata: pointer) {.gcsafe, raises: [Defect].}
-  executeRetentionPolicy = proc(udata: pointer) {.gcsafe.} =
-
-    try:
-      let retPolRes = waitFor w.executeMessageRetentionPolicy()
-      if retPolRes.isErr():
-        waku_archive_errors.inc(labelValues = [retPolicyFailure])
-        error "error in periodic retention policy", error = retPolRes.error
-    except CatchableError:
-      waku_archive_errors.inc(labelValues = [retPolicyFailure])
-      error "exception in periodic retention policy",
-            error = getCurrentExceptionMsg()
-
-    discard setTimer(Moment.fromNow(interval), executeRetentionPolicy)
+  var executeRetentionPolicy: CallbackFunc
+  executeRetentionPolicy =
+    CallbackFunc(
+      proc (arg: pointer) {.gcsafe, raises: [].} =
+        try:
+          let retPolRes = waitFor w.executeMessageRetentionPolicy()
+          if retPolRes.isErr():
+            waku_archive_errors.inc(labelValues = [retPolicyFailure])
+            error "error in periodic retention policy", error = retPolRes.error
+        except CatchableError:
+          waku_archive_errors.inc(labelValues = [retPolicyFailure])
+          error "exception in periodic retention policy",
+                error = getCurrentExceptionMsg()
+
+        discard setTimer(Moment.fromNow(interval), executeRetentionPolicy)
+    )
 
   discard setTimer(Moment.fromNow(interval), executeRetentionPolicy)
diff --git a/waku/waku_filter_v2/protocol.nim b/waku/waku_filter_v2/protocol.nim
@@ -255,10 +255,12 @@ const MaintainSubscriptionsInterval* = 1.minutes
 
 proc startMaintainingSubscriptions*(wf: WakuFilter, interval: Duration) =
   trace "starting to maintain subscriptions"
-  var maintainSubs: proc(udata: pointer) {.gcsafe, raises: [Defect].}
-  maintainSubs = proc(udata: pointer) {.gcsafe.} =
-    maintainSubscriptions(wf)
-    wf.maintenanceTask = setTimer(Moment.fromNow(interval), maintainSubs)
+  var maintainSubs: CallbackFunc
+  maintainSubs = CallbackFunc(
+    proc(udata: pointer) {.gcsafe.} =
+      maintainSubscriptions(wf)
+      wf.maintenanceTask = setTimer(Moment.fromNow(interval), maintainSubs)
+  )
 
   wf.maintenanceTask = setTimer(Moment.fromNow(interval), maintainSubs)
+0 −39		.appveyor.yml
+4 −4		.github/workflows/ci.yml
+0 −26		.travis.yml
+0 −2		README.md
+7 −18		chronicles.nim
+1 −1		chronicles.nimble
+13 −5		chronicles/log_output.nim
+1 −4		config.nims
+0 −118		nimble.lock
+1 −1		tests/perf/size_check_debug.test
+2 −2		.github/workflows/ci.yml
+1 −0		.gitignore
+1 −1		README.md
+21 −8		chronos.nimble
+9 −74		chronos/apps/http/httpbodyrw.nim
+322 −180		chronos/apps/http/httpclient.nim
+56 −4		chronos/apps/http/httpcommon.nim
+129 −0		chronos/apps/http/httpdebug.nim
+427 −243		chronos/apps/http/httpserver.nim
+5 −4		chronos/apps/http/httptable.nim
+15 −15		chronos/apps/http/multipart.nim
+29 −6		chronos/apps/http/shttpserver.nim
+405 −363		chronos/asyncfutures2.nim
+603 −213		chronos/asyncloop.nim
+158 −161		chronos/asyncmacro2.nim
+1,347 −0		chronos/asyncproc.nim
+48 −36		chronos/asyncsync.nim
+71 −4		chronos/config.nim
+5 −8		chronos/debugutils.nim
+251 −0		chronos/futures.nim
+7 −7		chronos/handles.nim
+23 −25		chronos/ioselects/ioselectors_epoll.nim
+33 −26		chronos/ioselects/ioselectors_kqueue.nim
+19 −22		chronos/ioselects/ioselectors_poll.nim
+407 −204		chronos/osdefs.nim
+1,348 −0		chronos/oserrno.nim
+122 −10		chronos/osutils.nim
+19 −15		chronos/ratelimit.nim
+9 −27		chronos/selectors2.nim
+14 −12		chronos/sendfile.nim
+3 −4		chronos/srcloc.nim
+52 −108		chronos/streams/asyncstream.nim
+26 −25		chronos/streams/tlsstream.nim
+416 −0		chronos/threadsync.nim
+1 −22		chronos/timer.nim
+103 −51		chronos/transports/common.nim
+78 −78		chronos/transports/datagram.nim
+6 −9		chronos/transports/ipnet.nim
+20 −21		chronos/transports/osnet.nim
+315 −283		chronos/transports/stream.nim
+12 −0		chronos/unittest2/asynctests.nim
+18 −6		tests/testall.nim
+150 −157		tests/testasyncstream.nim
+5 −5		tests/testbugs.nim
+4 −4		tests/testdatagram.nim
+486 −20		tests/testfut.nim
+26 −0		tests/testfutures.nim
+581 −133		tests/testhttpclient.nim
+256 −76		tests/testhttpserver.nim
+94 −1		tests/testmacro.nim
+1 −1		tests/testnet.nim
+42 −0		tests/testproc.bat
+468 −0		tests/testproc.nim
+28 −0		tests/testproc.sh
+38 −33		tests/testratelimit.nim
+61 −44		tests/testserver.nim
+9 −5		tests/testshttpserver.nim
+57 −38		tests/testsignal.nim
+74 −66		tests/testsoon.nim
+149 −71		tests/teststream.nim
+2 −2		tests/testsync.nim
+369 −0		tests/testthreadsync.nim
+17 −7		tests/testtime.nim
+3 −3		tests/testutils.nim
+3 −3		.github/workflows/ci.yml
+20 −15		nimcrypto.nimble
+0 −2		nimcrypto/bcmode.nim
+3 −4		nimcrypto/blake2.nim
+0 −3		nimcrypto/blowfish.nim
+45 −6		nimcrypto/hash.nim
+3 −4		nimcrypto/hmac.nim
+3 −4		nimcrypto/keccak.nim
+0 −2		nimcrypto/rijndael.nim
+3 −4		nimcrypto/ripemd.nim
+2 −2		nimcrypto/scrypt.nim
+3 −4		nimcrypto/sha.nim
+3 −4		nimcrypto/sha2.nim
+0 −1		nimcrypto/sysrand.nim
+0 −3		nimcrypto/twofish.nim
+16 −70		nimcrypto/utils.nim
+1 −1		tests/bootstrap.bat
+5 −5		tests/bootstrap.sh
+30 −0		tests/testapi.nim
+19 −1		tests/testutils.nim