Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decoupling announced and listen addresses #2203

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

gabrielmer
Copy link
Contributor

Description

Currently, our logs don't distinguish between the addresses we announce to the outside world vs the addresses our node is actually listening on. We used to only print "Listening on", and included there only the addresses we announced.

Fixed wording and added a log with the addresses our node is bound to.
In addition, included the LAN IP in the new log for convenience.

Changes

  • moved network information logs to be printed after the switch binds and starts listening
  • separated logging for announced addresses and listening addresses
  • added LAN IP to the logs

image

Issue

closes #2148

@gabrielmer gabrielmer changed the title Chore logging local ip address chore: decoupling announced and listen addresses Nov 9, 2023
@gabrielmer gabrielmer self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2203

Built from 7826ec1

@gabrielmer gabrielmer marked this pull request as ready for review November 10, 2023 11:16
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

waku/node/waku_node.nim Show resolved Hide resolved
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM!

@gabrielmer gabrielmer merged commit ef8ffbd into master Nov 16, 2023
9 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-logging-local-ip-address branch November 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: decouple listen and announced addresses
3 participants