Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): logs, updated submodule, leaves_set metric #2024

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 12, 2023

Description

This PR includes very minor changes to improve qol

Changes

  • logging from fromBlock while syncing
  • updated zerokit submodule to v0.3.3
  • updated metric logging for memberships

Note

To make sure you don't get errors while linking librln.a, remove the file from the project root

@rymnc rymnc self-assigned this Sep 12, 2023
@rymnc rymnc requested a review from alrevuelta September 12, 2023 10:20
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2024

Built from bd0d8dc

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alrevuelta
Copy link
Contributor

@vpavlin does the bot post the correct "Built from 4617f6e"? Commit is 02799fe, so seems there is a missmatch, or?

@rymnc
Copy link
Contributor Author

rymnc commented Sep 13, 2023

@vpavlin is it okay if we merge this after the release tomorrow/?

@vpavlin
Copy link
Member

vpavlin commented Sep 14, 2023

@vpavlin does the bot post the correct

Yes and no, it seems like it is merging the PR to the master and building it, which results in different commit in local checkout than where it built from (at least I think that's what is happening?). Will need to look into how to get the actual commit hash again, sorry about this..

@vpavlin
Copy link
Member

vpavlin commented Sep 14, 2023

@vpavlin is it okay if we merge this after the release tomorrow/?

It's fine, unless it should be part of the release? We are still waiting for #2031, to prevent the DB issues

@rymnc rymnc merged commit 2e515a0 into master Sep 18, 2023
@rymnc rymnc deleted the chores-rln-relay branch September 18, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants