refactor(cbindings): waku_thread.nim - Using 'ThreadSignalPtr' instead of loop to handle req/resp #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 48165c1 |
Ivansete-status
force-pushed
the
thread-safe-signals-instead-of-loop
branch
from
7b0ed28 to
f7ab24e
Compare
Ivansete-status
force-pushed
the
thread-safe-signals-instead-of-loop
branch
from
f7ab24e to
bb6a018
Compare
Ivansete-status
requested review from
arnetheduck,
vpavlin,
jm-clius and
NagyZoltanPeter
NagyZoltanPeter
approved these changes
Sep 19, 2023
jm-clius
approved these changes
Sep 22, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use of a better approach to synchronize threads. Use of
ThreadSignalPtrinstead of an intense loop.This PR is motivated by the following comment: #1978 (comment)