Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): Bumping some vendors #2048

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Sep 19, 2023

Description

The next vendors are being bumped:

dnsclient.nim
nim-bearssl
nim-eth
nim-faststreams
nim-http-utils
nim-json-rpc
nim-json-serialization
nim-libbacktrace
nim-metrics
nim-regex
nim-secp256k1
nim-stint
nim-testutils

Issue

#2041

@Ivansete-status Ivansete-status self-assigned this Sep 19, 2023
dnsclient.nim
nim-bearssl
nim-eth
nim-faststreams
nim-http-utils
nim-json-rpc
nim-json-serialization
nim-libbacktrace
nim-metrics
nim-regex
nim-secp256k1
nim-stew
nim-stint
nim-testutils
@Ivansete-status Ivansete-status changed the title chore(maintenance): Bumping some vendors (2/3) chore(maintenance): Bumping some vendors Sep 19, 2023
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2048

Built from 0308c67

@Ivansete-status Ivansete-status marked this pull request as ready for review September 20, 2023 08:52
@vpavlin
Copy link
Member

vpavlin commented Sep 20, 2023

Would it make sense to run a simulation from this PR and see if any unexpected errors show up in logs?

@Ivansete-status
Copy link
Collaborator Author

Ivansete-status commented Sep 20, 2023

Would it make sense to run a simulation from this PR and see if any unexpected errors show up in logs?

Yes, very good point. The idea that I had was to check if errors occur in the wakuv2.test fleet once this is merged.

edited: this can be tested already thanks to the temporary image from quay 🔥

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@Ivansete-status Ivansete-status merged commit 8f8d1ef into master Sep 20, 2023
20 checks passed
@Ivansete-status Ivansete-status deleted the vendor-bump branch September 20, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants