refactor: Moved external APIs out of node #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
added
the
E:1.4: Sharded peer management and discovery
SionoiS
requested review from
vpavlin,
alrevuelta,
jm-clius,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
SionoiS
changed the title
|
You can find the image built from this PR at Built from 7f83c3d |
Ivansete-status
approved these changes
Sep 22, 2023
I haven't looked into it yet but either reorganize some files only OR move the logic to the app layer. As for why, managing peers is always app specific. A light node that only use light push and filter is not going to manage peers the same as a full node with relay enabled for multiple shards. |
SionoiS
force-pushed
the
chore--moving-external-api
branch
from
951da9e to
92bb6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JSONRPC and REST APIs are no longer part of
node. I created awaku_apifolder for them.This would be the first step in a bigger refactoring effort. Next step would be to move peer manager out of
nodeas well.Tracking #1941