fix: waku_filter_v2/common: PEER_DIAL_FAILURE ret code change: 200 -> 504

[Ivansete-status]

Changing the return code to a more meaningful value when PEER_DIAL_FAILURE happens.

[danisharora099]

thanks!

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2236

Built from 350e384

[jm-clius]

LGTM and this should definitely be an error code.

Note however that it was chosen to correspond with what is already implemented for Store:

nwaku/waku/waku_store/common.nim

Line 66 in 59ee3c6

PEER_DIAL_FAILURE = uint32(200)

and would have to be fixed there as well.

Less important, but something to consider:
504 is also the HTTP error code for Gateway Timeout, which is very similar/equivalent to peer dial failure. Should we consider sticking to HTTP terminology? All other error codes are chosen to mirror the HTTP codes

[SionoiS]

Much better thanks!

[SionoiS]

There are a couples of TODOs in the code base and I always think to myself. Why not just change it instead of adding a TODO your touching this part of the code anyway. If you need to remember to do something later should open an issue IMO.

[Ivansete-status]

Less important, but something to consider: 504 is also the HTTP error code for Gateway Timeout, which is very similar/equivalent to peer dial failure. Should we consider sticking to HTTP terminology? All other error codes are chosen to mirror the HTTP codes

Thanks for the heads-up!
The idea is to follow the HTTP terminology.