Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: peer_manager.nim - reduce logs from debug to trace #2279

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR to reduce log spamming from peer_manager.nim.
I changed all the logs. Feel free to comment any log that don't want to change.

Changes

  • Change log level from debug to trace in peer_manager.nim.

Issue

closes #1562

@Ivansete-status Ivansete-status self-assigned this Dec 8, 2023
@Ivansete-status Ivansete-status marked this pull request as ready for review December 8, 2023 10:49
Copy link

github-actions bot commented Dec 8, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2279

Built from 356f9b2

@SionoiS
Copy link
Contributor

SionoiS commented Dec 8, 2023

Sorry I forgot to put them back to trace.....

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pruning connection due to ip colocation

may be useful, other than that lgtm

@Ivansete-status Ivansete-status merged commit 0cc0c80 into master Dec 12, 2023
8 checks passed
@Ivansete-status Ivansete-status deleted the reduce-peer-mngm-logs branch December 12, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove/move to trace some peer_manager logs
3 participants