Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CHANGELOG.md to reflect bug fix for issue #2317 #2340

Merged
merged 4 commits into from
Jan 10, 2024
Merged

chore: Update CHANGELOG.md to reflect bug fix for issue #2317 #2340

merged 4 commits into from
Jan 10, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Update CHANGELOG.md to reflect the latest v0.23.1 version created.

@Ivansete-status Ivansete-status self-assigned this Jan 9, 2024
@Ivansete-status Ivansete-status marked this pull request as ready for review January 9, 2024 13:02
gabrielmer
gabrielmer reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to change this date

nwaku/CHANGELOG.md

Line 1 in e30a024

## v0.23.1 (2023-01-05)

gabrielmer
gabrielmer reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's missing the metadata protocol here, it appears in the footer of 0.23.0

nwaku/CHANGELOG.md

Lines 13 to 19 in e30a024

It supports the same [libp2p protocols](https://docs.libp2p.io/concepts/protocols/):
| Protocol | Spec status | Protocol id |
| ---: | :---: | :--- |
| [`11/WAKU2-RELAY`](https://rfc.vac.dev/spec/11/) | `stable` | `/vac/waku/relay/2.0.0` |
| [`12/WAKU2-FILTER`](https://rfc.vac.dev/spec/12/) | `draft` | `/vac/waku/filter/2.0.0-beta1` <br />`/vac/waku/filter-subscribe/2.0.0-beta1` <br />`/vac/waku/filter-push/2.0.0-beta1` |
| [`13/WAKU2-STORE`](https://rfc.vac.dev/spec/13/) | `draft` | `/vac/waku/store/2.0.0-beta4` |
| [`19/WAKU2-LIGHTPUSH`](https://rfc.vac.dev/spec/19/) | `draft` | `/vac/waku/lightpush/2.0.0-beta1` |

SionoiS
SionoiS approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

gabrielmer
gabrielmer approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! 🤩

@Ivansete-status Ivansete-status merged commit 8ce8ec6 into master Jan 10, 2024
8 checks passed
@Ivansete-status Ivansete-status deleted the update-change-log branch January 10, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivansete-status @SionoiS @gabrielmer