Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stdef.h to libwaku.h #2409

Merged
merged 2 commits into from
Feb 13, 2024
Merged

chore: add stdef.h to libwaku.h #2409

merged 2 commits into from
Feb 13, 2024

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Feb 8, 2024

Description

While generating the bindings for rust, I ran into the error unknown type name 'size_t'. This PR adds a header to libwaku.h to fix that problem.

Curiously enough, in the c-bindings example we don't have such error because we include stdio.h which includes stddef.h

Copy link

github-actions bot commented Feb 8, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2409

Built from ce4b94a

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for it!

@richard-ramos richard-ramos requested a review from SionoiS February 9, 2024 16:09
@richard-ramos richard-ramos merged commit d58aca0 into master Feb 13, 2024
9 of 10 checks passed
@richard-ramos richard-ramos deleted the stddef.h branch February 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants