chore(rln-relay): remove wss support from node config #2442
Conversation
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
| confutils, confutils/defs, confutils/std/net, | ||
| eth/keys, | ||
| libp2p/crypto/crypto, | ||
| libp2p/crypto/secp, | ||
| nimcrypto/utils, | ||
| eth/keys | ||
| std/strutils, | ||
| regex |
| chronos, | ||
| std/strutils, | ||
| stew/results, | ||
| stew/shims/net | ||
| stew/shims/net, | ||
| regex |
rymnc
added
release-notes
rymnc
requested review from
Ivansete-status and
alrevuelta
and removed request for
Ivansete-status
|
You can find the image built from this PR at Built from 2f0ecd3 |
rymnc
force-pushed
the
remove-wss-rln-relay
branch
from
16bb0b5 to
c7e1301
Compare
|
will leave this PR open until the appropriate pr has been merged in: status-im/infra-waku#11 |
| return @[] | ||
|
|
||
| proc parseCmdArg*(T: type EthRpcUrl, s: string): T = | ||
| var httpPattern = re2"^(https?:\/\/)(?:w{1,3}\.)?[^\s.]+(?:\.[a-z]+)*(?::\d+)?(?![^<]*(?:<\/\w+>|\/?>))" |
There was a problem hiding this comment.
Shall we have examples of the regex, in a comment? The same applies elsewhere
|
rln docs updated: 8e59705 |
Description
Removes wss as a valid configuration to wakunode2, networkmonitor, chat2
Changes
How to test
make -j16 wakunode2Issue
closes #2434