Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better error logs in sharding mismatch and avoid checking clusterId if clusterId == 0 #2445

Closed

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Feb 17, 2024

Description

  1. Enhance error management inside isClusterMismatched
  2. Avoid validation inside isClusterMismatched if the node is using clusterId == 0. This aims to allow the node to start successfully and avoid the appearance of "cluster id mismatch configured shards" and the quit(QuitFailure). In other words, the node couldn't start due to this proc even though the clusterId param was not being set.

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2445

Built from 188e841

@Ivansete-status Ivansete-status marked this pull request as ready for review February 17, 2024 00:55
@Ivansete-status Ivansete-status self-assigned this Feb 17, 2024
@SionoiS
Copy link
Contributor

SionoiS commented Feb 19, 2024

It was this way before. See here https://github.com/waku-org/nwaku/pull/2368/files

You have to check if shards have been set when cluster id == 0 too, otherwise no error is returned when a node is launched with only shards and no cluster id (default 0).

@gabrielmer
Copy link
Contributor

This PR would also reintroduce #2311 , I think we should allow nodes to start without subscribed shards and subscribe later dynamically

@SionoiS
Copy link
Contributor

SionoiS commented Feb 19, 2024

allow nodes to start without subscribed shards and subscribe later dynamically

I would be very ergonomic indeed.

@Ivansete-status
Copy link
Collaborator Author

Thanks for the comments guys!
Disregard this PR.
For some reason, last week we had many restarts in waku.fleet due to this proc, and the PR was motivated to overcome that. It also happened to me locally but now it works well :)

image

Anyways, I'll close this.

@Ivansete-status Ivansete-status deleted the better-error-logs-in-sharding-mismatch branch May 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants