Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moving node initialization code to node_factory.nim #2479

Merged
merged 16 commits into from
Mar 3, 2024
Merged

chore: moving node initialization code to node_factory.nim #2479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
67834b4
Moving node initialization code to node_factory.nim
gabrielmer Feb 27, 2024
4ff9eb7
removing setupProtocols from app
gabrielmer Feb 27, 2024
765ff3d
removing startNode from app
gabrielmer Feb 27, 2024
30f76c6
removing comments
gabrielmer Feb 27, 2024
cd3150a
moving external_config, internal_config and wakunode2_validator_signe…
gabrielmer Feb 27, 2024
4857657
renaming wakunode2_validator_signed to validator_signed
gabrielmer Feb 27, 2024
f7faf36
fixing import
gabrielmer Feb 27, 2024
49c1bd7
moving external_config.nim back to apps directory
gabrielmer Feb 27, 2024
b19da32
reordering into factory module
gabrielmer Feb 28, 2024
7ec013b
moving validator_signed to factory directory
gabrielmer Feb 28, 2024
e54ceca
Fixing test and cleaning diff
gabrielmer Feb 28, 2024
f01e18c
more diff cleaning
gabrielmer Feb 28, 2024
dac239f
adding missing import
gabrielmer Feb 28, 2024
9d20eec
missing import
gabrielmer Feb 28, 2024
88b6554
moving builder.nim to factory
gabrielmer Feb 29, 2024
2d3710e
remove incorrect import
gabrielmer Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/chat2/chat2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import
../../waku/waku_node,
../../waku/node/waku_metrics,
../../waku/node/peer_manager,
../../waku/factory/builder,
../../waku/common/utils/nat,
./config_chat2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually it may be possible for all apps, including chat2, to start using the common factory/external_config and only add app-specific config items in an extension module. Nothing to action for now. :)


Expand Down
1 change: 1 addition & 0 deletions apps/chat2bridge/chat2bridge.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import
../../waku/waku_filter,
../../waku/waku_filter_v2,
../../waku/waku_store,
../../waku/factory/builder,
# Chat 2 imports
../chat2/chat2,
# Common cli config
Expand Down
1 change: 1 addition & 0 deletions apps/networkmonitor/networkmonitor.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import
../../waku/waku_discv5,
../../waku/waku_dnsdisc,
../../waku/waku_rln_relay,
../../waku/factory/builder,
../wakunode2/networks_config,
./networkmonitor_metrics,
./networkmonitor_config,
Expand Down
3 changes: 2 additions & 1 deletion apps/wakucanary/wakucanary.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import
../../waku/waku_enr,
../../waku/node/peer_manager,
../../waku/waku_core,
../../waku/waku_node
../../waku/waku_node,
../../waku/factory/builder

# protocols and their tag
const ProtocolsTable = {
Expand Down
Loading
Loading