chore: switch wakuv2 to waku fleet

[yakimant]

No description provided.

[Ivansete-status]

LGTM!

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2519-rln-v2-false

Built from c8b2050

[Ivansete-status]

LGTM! Great work! 💯

[SionoiS]

Very nice thanks!

Left some comments.

[NagyZoltanPeter]

Approve with little nitpick.
..and a question: While we have this https://fleets.status.im/ but wouldn't it be possible to store all these hard coded addresses in a git repository with some script could be used to retrieve the necessary set of addresses and store in env variables to be used within our apps?
Such solution would give flexibility and automation for using the necessary fleet without such hard coding.
WDYT? cc:@SionoiS @Ivansete-status @gabrielmer @jm-clius

[yakimant]

@NagyZoltanPeter, I admire your idea to extract hardcoded links and use https://fleets.status.im

Status Desktop and Mobile already do it. They store a copy of json in repo and update it with make target.

But this is out of the scope of this PR, I just want to replace the old references.
Although this PR can be useful for future work.

[yakimant]

@SionoiS, @NagyZoltanPeter, @Ivansete-status, some CI jobs are failing.
Was not trivial to figure out, what happened, can you plase help?

[SionoiS]

@SionoiS, @NagyZoltanPeter, @Ivansete-status, some CI jobs are failing. Was not trivial to figure out, what happened, can you plase help?

At first glace -> /home/runner/work/nwaku/nwaku/examples/publisher.nim(33, 3) Error: closing " expected

[NagyZoltanPeter]

@SionoiS, @NagyZoltanPeter, @Ivansete-status, some CI jobs are failing. Was not trivial to figure out, what happened, can you plase help?

At first glace -> /home/runner/work/nwaku/nwaku/examples/publisher.nim(33, 3) Error: closing " expected

@yakimant: Yes, @SionoiS is right. In commit: b609ec5 there is a missing closing apostrophe.
But I see there are other issues with it.

First of all it will be hard to merge in this way due to the nph formatting recently applied to the complete nwaku nim code base.
I can help with it if you need!

[NagyZoltanPeter]

@SionoiS, @NagyZoltanPeter, @Ivansete-status, some CI jobs are failing. Was not trivial to figure out, what happened, can you plase help?

At first glace -> /home/runner/work/nwaku/nwaku/examples/publisher.nim(33, 3) Error: closing " expected

@yakimant: Yes, @SionoiS is right. In commit: b609ec5 there is a missing closing apostrophe. But I see there are other issues with it.

First of all it will be hard to merge in this way due to the nph formatting recently applied to the complete nwaku nim code base. I can help with it if you need!

@yakimant: Did you start a rebase to latest origin/master? If so it has not been finished.
I fixed the code, will push it here to see if ci will go well.

[NagyZoltanPeter]

@yakimant, @SionoiS : I pushed fixes for the code and test. Tests seems running well... but not perfect.
ubuntu-latest-rln-v2 fails with port is already occupied that test would use for REST API.
Other tests just seems run out of time.... Any thoughts on it?

[yakimant]

@NagyZoltanPeter, thanks for fixing my stupid mistakes!

As for tests/test_waku_enr.nim - maybe let's change the ENR instead?
I think it would be nice to get rid of wakuv2 references at all.

[NagyZoltanPeter]

@NagyZoltanPeter, thanks for fixing my stupid mistakes!

As for tests/test_waku_enr.nim - maybe let's change the ENR instead? I think it would be nice to get rid of wakuv2 references at all.

Surely, but I did not know what exactly would be the correct expected result, while the test was just about to decode ENR properly.

[SionoiS]

@yakimant, @SionoiS : I pushed fixes for the code and test. Tests seems running well... but not perfect. ubuntu-latest-rln-v2 fails with port is already occupied that test would use for REST API. Other tests just seems run out of time.... Any thoughts on it?

I launched a re-run. Seams like flaky tests except, 1 test in the js interop failed with a shard error.
Maybe sharding info is wrong in some ENR?

[NagyZoltanPeter]

Seems much better now.
Only optional js-waku-node tests fails with timout.

 Peer Exchange
    Auto Discovery
      1) should discover peers other than used for bootstrapping on test fleet
      ✔ should discover peers other than used for bootstrapping on prod fleet (1566ms)


  6 passing (4m)
  1 failing

  1) Peer Exchange
       Auto Discovery
         should discover peers other than used for bootstrapping on test fleet:
     Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/nwaku/nwaku/packages/tests/tests/peer-exchange/pe.optional.spec.ts)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

As this error exists in general for other PR's CI jobs, @yakimant I think you can now merge this change!!!
Thank you for it.