chore: Enabling to use a full node for lightpush via rest api without lightpush client configured #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…push client configured
NagyZoltanPeter
requested review from
SionoiS,
alrevuelta,
jm-clius,
gabrielmer and
Ivansete-status
|
You can find the image built from this PR at Built from 9787e53 |
|
You can find the image built from this PR at Built from 9787e53 |
SionoiS
approved these changes
Apr 25, 2024
| @@ -35,6 +36,9 @@ const NoPeerNoDiscoError = | |||
| const NoPeerNoneFoundError = | |||
| RestApiResponse.serviceUnavailable("No suitable service peer & none discovered") | |||
|
|
|||
| proc useSelfHostedLightPush(node: WakuNode): bool = | |||
There was a problem hiding this comment.
Maybe rephrase to local vs remote lightpush ?
Comment on lines
+68
to
+70
| if useSelfHostedLightPush(node): | ||
| discard | ||
| else: |
There was a problem hiding this comment.
Suggested change
| if useSelfHostedLightPush(node): | |
| discard | |
| else: | |
| if not useSelfHostedLightPush(node): |
gabrielmer
approved these changes
Apr 25, 2024
NagyZoltanPeter
deleted the
chore-make-rest-lightpush-avail-on-service-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is helper enhancment for testing (rate limit specifically for me) on lightpush... similar to query self store node via REST API.
With this change one can issue lightpush request via REST API on a service node having lightpush protocol installed.
In contrast it was needed to run a full node with lightpush service and a light client (configured with the service node peerId) to be usable from REST API.
With this change a lightpush service node (with relay of course) can serve such lightpush API request and can relay such messages.
This can help in various way.
Changes
How to test
Open question: