-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding json string support to bindings config #2685
feat: adding json string support to bindings config #2685
Conversation
You can find the image built from this PR at
Built from 3cabc02 |
You can find the image built from this PR at
Built from 3cabc02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!!! Thank you!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Super elegant and concise!
Thanks for it! 💯
I just added some nitpick comments that I hope you find useful
library/waku_thread/inter_thread_communication/requests/node_lifecycle_request.nim
Outdated
Show resolved
Hide resolved
library/waku_thread/inter_thread_communication/requests/node_lifecycle_request.nim
Show resolved
Hide resolved
eb04391
to
9f1d5f0
Compare
This reverts commit 3687ff2.
9f1d5f0
to
e1bc28b
Compare
Description
Supporting setting a node's configuration using a json string
Changes
WakuNodeConf
object increateWaku
defaultWakuNodeConf()
to create aWakuNodeConf
instance with the default values defined inexternal_config.nim
parseCmdArg()
functions which are already defined inconfutils
parseCmdArg()
for sequenceslibrary/waku_thread/config.nim
How to test
Build libwaku:
Set your desired configurations in the following json string:
nwaku/examples/cbindings/waku_example.c
Lines 271 to 287 in 6a1af92
For example
Build
waku_example.c
:Run waku_example:
Issue
closes #2677