chore: libwaku - allow to properly set the log level in libwaku and unify a little #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 6e8b336 |
|
You can find the image built from this PR at Built from 6e8b336 |
NagyZoltanPeter
approved these changes
May 17, 2024
| buildLibrary name, "library/", "-d:chronicles_log_level=ERROR", "static" | ||
| buildLibrary name, | ||
| "library/", | ||
| """-d:chronicles_line_numbers -d:chronicles_runtime_filtering=on -d:chronicles_sinks="textlines,json" -d:chronicles_default_output_device=Dynamic -d:chronicles_disabled_topics="eth,dnsdisc.client" """, |
There was a problem hiding this comment.
Just wonder - although I see it is the default in nim.cfg also - why exactly these and only these topics are disabled??? I have no issue with it, just seems such a leftover...
There was a problem hiding this comment.
Just wonder - although I see it is the default in nim.cfg also - why exactly these and only these topics are disabled??? I have no issue with it, just seems such a leftover...
Yes, I agree that this sounds like a leftover. I think for now we can leave them as is and in case we miss those in the future we can reenable them
| # Adhere to NO_COLOR initiative: https://no-color.org/ | ||
| let color = | ||
| try: | ||
| not parseBool(os.getEnv("NO_COLOR", "false")) |
gabrielmer
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libwakuloggingmodule and have a standard logging setup.waku.nimwithininitproc.wakunode2we also set the log before "waku.init" is invoked because we need to setup the logs properly for the "essential rest server" that we start at the beginningIssue
closes #2411