-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: better descriptive log #2826
Conversation
You can find the image built from this PR at
Built from 4ee6e50 |
You can find the image built from this PR at
Built from 4ee6e50 |
You can find the image built from this PR at
Built from 30c0819 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! 💯
Just added a minor comment
waku/factory/node_factory.nim
Outdated
@@ -148,6 +148,8 @@ proc setupProtocols( | |||
conf.contentTopics.mapIt(node.wakuSharding.getShard(it).expect("Valid Shard")) | |||
let pubsubTopics = conf.pubsubTopics & shards | |||
|
|||
debug "Shards created for content filter", shards = shards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to give a bit more detail when we have contentTopics as a parameter
debug "Shards created for content filter", shards = shards | |
if conf.contentTopics.len > 0: | |
debug "Shards created from content topics", contentTopics = conf.contentTopics, shards = shards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
1ff33a2
to
bdbf463
Compare
Previously, there was confusion in distinguishing between the content and the pubsub topic in logs. Now, the logs are more descriptive, clearly specifying which content-topic pair has the issue.