chore: update content-topic parsing for filter

[darshankabariya]

close #2834

This is a minor change to fix bug #2834.

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2835

Built from 350796b

[NagyZoltanPeter]

Great catch, thank you!

[gabrielmer]

I think this should be run only if relay is configured. If filter is configured and relay isn't, with these changes we would still mount relay

nwaku/waku/factory/node_factory.nim

Lines 160 to 168 in 9691dfb

	try:
	await mountRelay(
	node,
	pubsubTopics,
	peerExchangeHandler = peerExchangeHandler,
	int(parsedMaxMsgSize),
	)
	except CatchableError:
	return err("failed to mount waku relay protocol: " & getCurrentExceptionMsg())

[darshankabariya]

I think this should be run only if relay is configured. If filter is configured and relay isn't, with these changes we would still mount relay

nwaku/waku/factory/node_factory.nim

Lines 160 to 168 in 9691dfb

	try:
	await mountRelay(
	node,
	pubsubTopics,
	peerExchangeHandler = peerExchangeHandler,
	int(parsedMaxMsgSize),
	)
	except CatchableError:
	return err("failed to mount waku relay protocol: " & getCurrentExceptionMsg())

Thanks for suggesting @gabrielmer !

[gabrielmer]

Thanks so much!

Added a last detail to align :))

[gabrielmer]

I think we should move this log to be right below

nwaku/waku/factory/node_factory.nim

Lines 147 to 148 in 11b575d

	let shards =
	conf.contentTopics.mapIt(node.wakuSharding.getShard(it).expect("Valid Shard"))