chore: Bump dependencies for v0.31.0 #2885
Conversation
Adding --mm:refc as nim 2.0 enables a new garbage collector that we're not yet ready to support
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 2648ed6 |
Ivansete-status
requested review from
SionoiS,
darshankabariya,
gabrielmer and
NagyZoltanPeter
There was a problem hiding this comment.
Excited about nim version bump!!!
Please notice this PR #2882 has overlap but above that unfortunately does not solve the issue with compile secp256k1 lib on latest MAC. Will tackle that issue further as soon as I have more information.
| @@ -231,7 +233,7 @@ proc query*(db: SqliteDatabase, query: string, onData: DataProc): DatabaseResult | |||
| else: | |||
| return err($sqlite3_errstr(v)) | |||
| return ok gotResults | |||
| finally: | |||
| except Exception, CatchableError: | |||
There was a problem hiding this comment.
Is finallyand the code below not still required if no exception raised?
There was a problem hiding this comment.
Sorry for the late response. I fixed that in #2891
Thanks!
Description
v0.31.0.1.6.0to2.0.8( caused by the bump ofnimbus-build-systemdependency .)--mm:refcis needed to be passed explicitly tonimwhen compiling as 2.0 enables a new garbage collector that we're not yet ready to support.db_connectorvendor dependency, which contains postgres types ( and other databases .) This is needed becausenimbus-build-systemno longer includes thedb_postgresmodule.( cc: so that you are aware we are bumping the Nim compiler version :) @fryorcraken, @jm-clius, @alrevuelta, @rymnc, @richard-ramos, @chaitanyaprem , @arnetheduck, @kaiserd, @AlejandroCabeza .)
Issue
closes #2876