Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faster retention policy when error and use of detach finalize when needed #2966

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

There are occasions where the concurrently-detach partition query didn't complete successfully. In those cases, the database shows an error hint recommending to perform a "finalize" detach partition. This PR aims at applying this approach when that error happens

Changes

  • Apply detach FINALIZE when recommended by the database
  • Speed up the retention policy application to once every minute, in case of error, so that we try again faster instead of waiting for 30 minutes each time.

Issue

closes #2890

@Ivansete-status Ivansete-status marked this pull request as ready for review August 12, 2024 07:45
Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2966

Built from e858246

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@darshankabariya darshankabariya self-requested a review August 12, 2024 08:43
Copy link
Contributor

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Ivansete-status Ivansete-status merged commit 71d4a11 into master Aug 12, 2024
10 of 12 checks passed
@Ivansete-status Ivansete-status deleted the fix-partition-deletion branch August 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: retention policy does not work when postgres db is over loaded
3 participants