Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: re-arrange function based on responsibility of peer-manager #3086

Merged
merged 4 commits into from
Oct 4, 2024
Merged

refactor: re-arrange function based on responsibility of peer-manager #3086

merged 4 commits into from
Oct 4, 2024

Conversation

darshankabariya
Copy link
Contributor

Refactored peer_manager.nim by organizing functions according to their responsibilities.

@darshankabariya darshankabariya marked this pull request as draft October 2, 2024 18:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3086

Built from b3049c4

@darshankabariya darshankabariya marked this pull request as ready for review October 3, 2024 05:31
@darshankabariya darshankabariya marked this pull request as draft October 3, 2024 10:39
SionoiS
SionoiS approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@darshankabariya darshankabariya marked this pull request as ready for review October 3, 2024 12:39
gabrielmer
gabrielmer approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@darshankabariya darshankabariya merged commit 0f8e874 into master Oct 4, 2024
9 of 11 checks passed
@darshankabariya darshankabariya deleted the pm_rearragement branch October 4, 2024 09:53
@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

Assignees

@darshankabariya darshankabariya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darshankabariya @SionoiS @gabrielmer @Ivansete-status