fix: avoid segfault by setting a default num peers requested in PX #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
Ivansete-status,
darshankabariya,
richard-ramos and
NagyZoltanPeter
|
You can find the image built from this PR at Built from 9fd30c5 |
NagyZoltanPeter
approved these changes
Oct 16, 2024
| @@ -57,7 +58,7 @@ type | |||
| requestRateLimiter*: RequestRateLimiter | |||
|
|
|||
| proc request*( | |||
| wpx: WakuPeerExchange, numPeers: uint64, conn: Connection | |||
| wpx: WakuPeerExchange, numPeers = DefaultPXNumPeersReq, conn: Connection | |||
There was a problem hiding this comment.
Is it necessary to apply default here? ... and for other variants?
There was a problem hiding this comment.
Over here it's not necessary! But added it because given that we now defined a default, it would make sense for that number to be used whenever no value is provided
richard-ramos
approved these changes
Oct 16, 2024
gabrielmer
force-pushed
the
fix-px-segfault-when-relay-not-mounted
branch
from
8de6ae9 to
c93e0a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Peer Exchange in nwaku, we are setting the number of peers requested by using a Relay-specific parameter, which isn't set if we use nwaku as a light client and produces a segfault.
Therefore, defined a
DefaultPXNumPeersReqconstant with a value of 5 to use whenever no argument is provided or whenever Relay is not mountedChanges
DefaultPXNumPeersReqconstantIssue
#3115