fix: peer exchange libwaku response handling #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
richard-ramos,
darshankabariya,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from 98f7406 |
5 tasks
richard-ramos
approved these changes
Oct 23, 2024
Ivansete-status
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way of parsing the Peer Exchange's responses in libwaku always returned an error, even if the call was successful. It also ignored the number of peers received.
Fixed the handling of
fetchPeerExchangePeers's responseChanges
fetchPeerExchangePeers's response in libwakuIssue
#3115