Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go-waku version #70

Merged
merged 3 commits into from
Sep 27, 2023
Merged

feat: update go-waku version #70

merged 3 commits into from
Sep 27, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 26, 2023

  • removes encoding functions from relay and lightpush
  • adds encode_symmetric and encode_asymmetric to WakuMessage
  • return an error instead of panics in decode_and_free_response

May fix #66

Copy link

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Still can't understand rust syntax completely though, but logic seems fine.

@richard-ramos richard-ramos force-pushed the update-waku-version branch 3 times, most recently from ee56d4d to 0fad3e9 Compare September 27, 2023 14:24
- removes encoding functions from relay and lightpush
- adds `encode_symmetric` and `encode_asymmetric` to `WakuMessage`
@hopeyen
Copy link

hopeyen commented Sep 27, 2023

confirmed this fixes #66 🎉 💯 Thanks very much for the collaboration! :shipit: 📦

@richard-ramos richard-ramos merged commit 32bd05c into master Sep 27, 2023
@richard-ramos richard-ramos deleted the update-waku-version branch September 27, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: protocol string 'sni' is unknown and causes panic
3 participants