Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: node handle constructor and messageId on publish #98

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

richard-ramos
Copy link
Member

Changes:

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 79.48%. Comparing base (8eb026d) to head (634a17f).

Files Patch % Lines
waku-bindings/tests/node.rs 57.14% 9 Missing ⚠️
waku-bindings/src/utils.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           handle-response      #98      +/-   ##
===================================================
- Coverage            80.05%   79.48%   -0.58%     
===================================================
  Files                   10       10              
  Lines                  722      736      +14     
===================================================
+ Hits                   578      585       +7     
- Misses                 144      151       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to bring back the type state pattern for WakuNodeHandle? That was nice.

@richard-ramos
Copy link
Member Author

richard-ramos commented Feb 28, 2024

ah! let's add that back in another PR

@richard-ramos
Copy link
Member Author

@SionoiS I added back the typestate in commit 98c6558

Base automatically changed from handle-response to nwaku March 1, 2024 15:25
@richard-ramos richard-ramos changed the base branch from nwaku to master March 1, 2024 15:30
@richard-ramos richard-ramos changed the base branch from master to nwaku March 1, 2024 15:30
@richard-ramos richard-ramos merged commit 69a4872 into nwaku Mar 1, 2024
@richard-ramos richard-ramos deleted the fix/msg-id branch March 1, 2024 15:31
@richard-ramos richard-ramos force-pushed the fix/msg-id branch 2 times, most recently from 634a17f to 0a5faa0 Compare March 1, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants