Remove unnecessary calls to toString

wala · Sep 22, 2024 · 5d708e3 · 5d708e3
1 parent 38c41b7
commit 5d708e3
Show file tree

Hide file tree

Showing 18 changed files with 26 additions and 26 deletions.
diff --git a/core/src/main/java/com/ibm/wala/analysis/reflection/AbstractReflectionInterpreter.java b/core/src/main/java/com/ibm/wala/analysis/reflection/AbstractReflectionInterpreter.java
@@ -112,7 +112,7 @@ protected static class ManySubtypesWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + T + ' ' + nImplementors;
+      return getClass() + " : " + T + ' ' + nImplementors;
     }
 
     public static ManySubtypesWarning create(TypeAbstraction T, int n) {
@@ -132,7 +132,7 @@ protected static class NoSubtypesWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + T;
+      return getClass() + " : " + T;
     }
 
     public static NoSubtypesWarning create(TypeAbstraction T) {

diff --git a/core/src/main/java/com/ibm/wala/cfg/ShrikeCFG.java b/core/src/main/java/com/ibm/wala/cfg/ShrikeCFG.java
@@ -550,7 +550,7 @@ private static class FailedExceptionResolutionWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + T;
+      return getClass() + " : " + T;
     }
 
     public static FailedExceptionResolutionWarning create(TypeReference T) {

diff --git a/core/src/main/java/com/ibm/wala/classLoader/BytecodeClass.java b/core/src/main/java/com/ibm/wala/classLoader/BytecodeClass.java
@@ -113,7 +113,7 @@ private static class ClassNotFoundWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + className;
+      return getClass() + " : " + className;
     }
 
     public static ClassNotFoundWarning create(ImmutableByteArray className) {

diff --git a/core/src/main/java/com/ibm/wala/classLoader/ClassLoaderFactoryImpl.java b/core/src/main/java/com/ibm/wala/classLoader/ClassLoaderFactoryImpl.java
@@ -146,7 +146,7 @@ private static class InvalidClassLoaderImplementation extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + impl;
+      return getClass() + " : " + impl;
     }
 
     public static InvalidClassLoaderImplementation create(String impl) {

diff --git a/core/src/main/java/com/ibm/wala/classLoader/ClassLoaderImpl.java b/core/src/main/java/com/ibm/wala/classLoader/ClassLoaderImpl.java
@@ -350,7 +350,7 @@ private static class MultipleImplementationsWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + className;
+      return getClass() + " : " + className;
     }
 
     public static MultipleImplementationsWarning create(String className) {
@@ -370,7 +370,7 @@ private static class InvalidClassFile extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + className;
+      return getClass() + " : " + className;
     }
 
     public static InvalidClassFile create(String className) {

diff --git a/core/src/main/java/com/ibm/wala/core/util/shrike/Exceptions.java b/core/src/main/java/com/ibm/wala/core/util/shrike/Exceptions.java
@@ -28,7 +28,7 @@ public static class MethodResolutionFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + method;
+      return getClass() + " : " + method;
     }
 
     public static MethodResolutionFailure moderate(MemberReference method) {

diff --git a/core/src/main/java/com/ibm/wala/ipa/callgraph/impl/AbstractRootMethod.java b/core/src/main/java/com/ibm/wala/ipa/callgraph/impl/AbstractRootMethod.java
@@ -316,7 +316,7 @@ private static class AllocationFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + t;
+      return getClass() + " : " + t;
     }
 
     public static AllocationFailure create(TypeReference t) {

diff --git a/core/src/main/java/com/ibm/wala/ipa/callgraph/impl/BasicCallGraph.java b/core/src/main/java/com/ibm/wala/ipa/callgraph/impl/BasicCallGraph.java
@@ -354,7 +354,7 @@ public void summarizeByPackage() {
               .append('/')
               .append(n.getMethod().getName())
               .append('/')
-              .append(n.getContext().getClass().toString());
+              .append(n.getContext().getClass());
 
       if (n.getContext().isA(ReceiverInstanceContext.class)) {
         nmBuilder

diff --git a/core/src/main/java/com/ibm/wala/ipa/callgraph/propagation/PropagationCallGraphBuilder.java b/core/src/main/java/com/ibm/wala/ipa/callgraph/propagation/PropagationCallGraphBuilder.java
@@ -276,7 +276,7 @@ private static class EntrypointResolutionWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + entrypoint;
+      return getClass() + " : " + entrypoint;
     }
 
     public static EntrypointResolutionWarning create(Entrypoint entrypoint) {
@@ -467,7 +467,7 @@ private static class ExceptionLookupFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + t;
+      return getClass() + " : " + t;
     }
 
     public static ExceptionLookupFailure create(TypeReference t) {

diff --git a/.../src/main/java/com/ibm/wala/ipa/callgraph/propagation/SSAPropagationCallGraphBuilder.java b/.../src/main/java/com/ibm/wala/ipa/callgraph/propagation/SSAPropagationCallGraphBuilder.java
@@ -2417,7 +2417,7 @@ private static class CheckcastFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + type;
+      return getClass() + " : " + type;
     }
 
     public static CheckcastFailure create(TypeReference type) {
@@ -2440,7 +2440,7 @@ private static class FieldResolutionFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + field;
+      return getClass() + " : " + field;
     }
 
     public static FieldResolutionFailure create(FieldReference field) {

diff --git a/core/src/main/java/com/ibm/wala/ipa/cha/ClassHierarchy.java b/core/src/main/java/com/ibm/wala/ipa/cha/ClassHierarchy.java
@@ -1259,7 +1259,7 @@ private static class ClassExclusion extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + klass + ' ' + message;
+      return getClass() + " : " + klass + ' ' + message;
     }
 
     public static ClassExclusion create(TypeReference klass, String message) {

diff --git a/core/src/main/java/com/ibm/wala/ipa/cha/ClassHierarchyWarning.java b/core/src/main/java/com/ibm/wala/ipa/cha/ClassHierarchyWarning.java
@@ -24,7 +24,7 @@ public class ClassHierarchyWarning extends Warning {
 
   @Override
   public String getMsg() {
-    return getClass().toString() + " : " + message;
+    return getClass() + " : " + message;
   }
 
   public static ClassHierarchyWarning create(String message) {

diff --git a/core/src/main/java/com/ibm/wala/ssa/SSACFG.java b/core/src/main/java/com/ibm/wala/ssa/SSACFG.java
@@ -1117,7 +1117,7 @@ private static class ExceptionLoadFailure extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + type + ' ' + method;
+      return getClass() + " : " + type + ' ' + method;
     }
 
     public static ExceptionLoadFailure create(TypeReference type, IMethod method) {

diff --git a/dalvik/src/main/java/com/ibm/wala/dalvik/classLoader/DexCFG.java b/dalvik/src/main/java/com/ibm/wala/dalvik/classLoader/DexCFG.java
@@ -690,7 +690,7 @@ private static class FailedExceptionResolutionWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + T;
+      return getClass() + " : " + T;
     }
 
     public static FailedExceptionResolutionWarning create(TypeReference T) {

diff --git a/dalvik/src/main/java/com/ibm/wala/dalvik/classLoader/WDexClassLoaderImpl.java b/dalvik/src/main/java/com/ibm/wala/dalvik/classLoader/WDexClassLoaderImpl.java
@@ -194,7 +194,7 @@ private static class MultipleDexImplementationsWarning extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + className;
+      return getClass() + " : " + className;
     }
 
     public static MultipleDexImplementationsWarning create(String className) {
@@ -214,7 +214,7 @@ private static class InvalidDexFile extends Warning {
 
     @Override
     public String getMsg() {
-      return getClass().toString() + " : " + className;
+      return getClass() + " : " + className;
     }
 
     public static InvalidDexFile create(String className) {

diff --git a/dalvik/src/main/java/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java b/dalvik/src/main/java/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModel.java
@@ -915,7 +915,7 @@ public SummarizedMethod getMethodAs(
       System.err.println("\tcaller=\t" + caller);
       System.err.println("\tinfo=\t" + info);
       System.err.println("\tcallerND=\t" + callerNd);
-      System.err.println("\tthis=\t" + this.getClass().toString());
+      System.err.println("\tthis=\t" + this.getClass());
       System.err.println("\tthis.name=\t" + this.name);
 
       throw new IllegalStateException(e);
@@ -954,7 +954,7 @@ public IMethod getMethodEncap() throws CancelException {
         new TypeSafeInstructionFactory(getClassHierarchy());
     final ParameterAccessor acc = new ParameterAccessor(asMethod, /* hasImplicitThis: */ false);
     final SSAValueManager pm = new SSAValueManager(acc);
-    pm.breadCrumb = "Encap: " + this.getClass().toString();
+    pm.breadCrumb = "Encap: " + this.getClass();
 
     final SummarizedMethod model = getMethod();
 

diff --git a/dalvik/src/main/java/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java b/dalvik/src/main/java/com/ibm/wala/dalvik/ipa/callgraph/androidModel/AndroidModelClass.java
@@ -104,7 +104,7 @@ public static AndroidModelClass getInstance(IClassHierarchy cha) {
       throw new IllegalArgumentException(
           String.format(
               "android model class does not have expected type %s, but %s!",
-              AndroidModelClass.class, android.getClass().toString()));
+              AndroidModelClass.class, android.getClass()));
     } else {
       mClass = (AndroidModelClass) android;
     }

diff --git a/dalvik/src/main/java/com/ibm/wala/dalvik/util/AndroidManifestXMLReader.java b/dalvik/src/main/java/com/ibm/wala/dalvik/util/AndroidManifestXMLReader.java
@@ -587,7 +587,7 @@ public void leave() {
               names.add((String) oName);
             } else {
               throw new IllegalStateException(
-                  "Unexpected Attribute type for name: " + oName.getClass().toString());
+                  "Unexpected Attribute type for name: " + oName.getClass());
             }
           } else if (current == Tag.DATA) {
             Object oUrl = attributesHistory.get(Attr.SCHEME).peek();
@@ -597,7 +597,7 @@ public void leave() {
               urls.add((String) oUrl);
             } else {
               throw new IllegalStateException(
-                  "Unexpected Attribute type for name: " + oUrl.getClass().toString());
+                  "Unexpected Attribute type for name: " + oUrl.getClass());
             }
           } else {
             throw new IllegalStateException("Error in parser implementation");
@@ -671,7 +671,7 @@ public void leave() {
               overrideTargets.add((Intent) oIntent);
             } else {
               throw new IllegalStateException(
-                  "Unexpected Attribute type for Intent: " + oIntent.getClass().toString());
+                  "Unexpected Attribute type for Intent: " + oIntent.getClass());
             }
           } else {
             throw new IllegalStateException("Error in parser implementation");