This repository has been archived by the owner on May 22, 2023. It is now read-only.
Modified default column width based on device width #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On iPhone plus series and smaller (414px and lower) ** Default column width is screen width ** Min column width is half of screen width, enabling two column layout * On portrait tablet (768px to 415px) ** Default column width is half of screen width ** Min column width is third of screen width, enable three column layout
|
Sorry this has been left open for so long! I don't know how well it reacts to changes in window size (either resizing on desktop or caused by rotations, etc), but in any case it feels like too specific of a use-case to me |
|
No worries, there is no on resize bindings, just on load, maybe I should add that. Anyways, since you're working on something new already, you can leave this be, at least it's working like I wanted on my server for now lol. The use case is.. just increasing mobile friendliness, I don't know how many % of the userbase accesses raidfinder from mobile so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushed and tested at my heroku, might need more testing. Also, my first time writing Scala, were you to accept this idea, feel free to rewrite the code.