-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moar style switch seems broken and not working #159
Comments
one more thing this help section also seems showing the wrong switch like it showing (-style) but if I am correct it should be |
Both flags are accepted and correct, |
@walles @m3tav3rse Thanks for your comment and input. I don't know why but it's not working for me John here is output of value you requested |
If you have
|
There is no highlighting for Ref: #128 (comment) |
I didn't get it. Do you mean to say the style color only works with programming files and for the rest other file types like txt and log, use the terminal color. but BAT has no such limit.. it can render color style for any file whatever I choose But yes syntax highlight will work only for programming files. I expect same with moar ... request you to add this if missing Not asking to highlight syntax through BAT support but at least color change for file I parse in moar |
"Syntax highlight" is what moar provides through Chroma (I think). But what is "color style"? And how is that different from syntax highlight? Maybe if you have a screenshot of what you'd expect then that could clarify this? |
so I thought suppose my terminal theme is Gruvbox but when I read and log file through moar then it uses Dracula color rendering so thought color style is the option to do so..BAT do this for me. |
What command line did you use to get this? That's a shell script, and if it's named |
Ran command moar .exports and bat .exports in kitty terminal . As I said I already tested all combo before raising ticket |
I experimented a bit and it seems like Sort of related to #134. It might be possible to have This would likely fix the |
hmm okay thanks John |
But This one seems broader, but doesn't detect shell scripts: Same for this one, doesn't detect shell scripts: This one has native dependencies, making it impractical: Other suggestions welcome, none of the above are usable for this out of the box unfortunately. |
This one seems nice, but requires the user to have Tensorflow installed, which I assume most people don't: |
@walles Thanks a lot my friend for all your support and time on this. Yes, many and even I don't like 10 other dependencies installed to run 1 software. That's ok you can leave I use BAT for such needs as |
Yet another candidate that doesn't recognize shell scripts: |
@walles it's not about shell script i feel scripts anyway moar is able to recognize |
What text file formats would be important for you? |
txt and log these are 2 most common type |
Neither of those have any highlighting, so even if they were detected correctly they wouldn't receive any highlighting anyway. |
@walles there is highlight for log in BAT but point is not about highlight..seems you not getting the request fully I said suppose my terminal theme is solarize and want my moar to render any log in color of gruvbox .. I gave you the screenshot above for very same comparision |
Do you mean that the text of the log should have some certain color based on the theme (gruvbox)? |
@walles just noticed the screenshot and understands the requirement. below SS my terminal theme is Solarize dark and when I ran bat <file_name.log> the color of text is a little yellowish and some numeric and hex values were highlighted Whereas when I ran same thing in moar in second SS. You will see it used the Solarize theme colour style only for text though I have color style gruvbox chosen in moar With gruvbox color style in BAT:-- With gruvbox color style in moar:-- Ideally when I choose the color style gruvbox in moar then color of text should be little yellowish as in first screenshot. Now I hope you understand the requirement |
After cbbdaf6, just released with v1.18.1, this should now work on 256 color terminals as well. |
@walles you said that 1.8.0 will have syntax highlights like bat to some extent for log/text files like in bat screenshot above but I don't see it .. |
Try v1.18.1. |
ok thanks, waiting for the release update to be available |
@walles just upgraded to 1.18.1 but the result is not what asked second I don't know what changes you did but anyway thank you so much for all your hard work |
If you want real highlighting of After it's implemented there then Here's what |
@walles now try Dracula and cappuccino-macchiato style and see what moar color is rendering.. you can see the below SS output moar is producing totally different style |
I'll need to bump Chroma to a newer version for this, the catppuccin themes were updated in July: |
@walles Thanks, In fact for another style.. the result outcome is not that good I means only this area Moar lack a functionality compare to BAT else moar has unmatched and the best tool |
If you want log file highlighting you have to request it here: |
The request is already raised but I don't know whether they will do it or not. |
@walles is this --style=catppuccin-macchiato? issue resolved as I am still having the problem and this style showing red color |
Just released |
ok Thanks! |
I have tried moar --style=gruvbox and suppose that moar will render the color format in gruvbox theme but it seems not working and moar is using default terminal theme color style for moar.. Running latest moar version on macOS sonoma 14.0 version. Ideally it should use the terminal theme style only when no --style switch option used along with moar
The text was updated successfully, but these errors were encountered: