Release two architectures for macOS

[xeago]

No description provided.

[walles]

Since the start of that comment might have just drowned in the build lot I'll just write it again:

This fails for me with (newly added flag) release.sh --dry. I'm on an x86 Mac / 10.15 Catalina, what's your setup?

[walles]

Question posted here: https://stackoverflow.com/questions/66849112/cross-compile-rust-from-macos-x86-to-macos-silicon

[xeago]

Hmm, I've tried again, commented the building of the linux binary (for which the musl toolchain fails to install thus far). Using M1 with Big Sur (11.2.3), and perhaps key to this Xcode 12.4. I think as of Xcode 12.2 these headers are included on Catalina too.

What version of Xcode is being used on your end and in CI?

[xeago]

I also believe you'll have issues testing the arm64 variant; you'll be unable to invoke it for --version. For what it's worth, lipo target/*-apple-darwin/release/riff -create universal makes this a universal binary.

Overall; this is somewhat of a mess, apologies for dragging you down this rabbit hole.

[walles]

Overall; this is somewhat of a mess, apologies for dragging you down this rabbit hole.

Rabbit hole schmabbit school this is where you learn stuff :)

[walles]

the musl toolchain fails to install thus far

Just for clarity, there's a comment in release.sh saying you have to do brew install FiloSottile/musl-cross/musl-cross.

Is it that brew invocation that doesn't work for you?

[xeago]

A week ago that brew invocation failed after ~2 hours, I can't quite remember specifically why, saw something about certain symbols not being found, in a few million lines of output. I'm giving it another try. :)

[xeago]

I find it interesting you were required to set SDKROOT, that should come by default with newer versions of Xcode. I suppose this will break explicitly on older versions of Xcode?

[xeago]

brew install FiloSottile/musl-cross/musl-cross:

                 code_helper code, const tree type, tree op0, tree op1, tree op2, tree op3, tree op4)
                                                                                       ^
gimple-match.c:99340:98: warning: unused parameter 'op4' [-Wunused-parameter]
                 code_helper code, const tree type, tree op0, tree op1, tree op2, tree op3, tree op4)
                                                                                                 ^
41 warnings generated.
166 warnings generated.
171 warnings generated.
rm -rf libbackend.a
ar rc libbackend.a gimple-match.o generic-match.o insn-attrtab.o insn-automata.o insn-dfatab.o insn-emit.o insn-extract.o insn-latencytab.o insn-modes.o insn-opinit.o insn-output.o insn-peep.o insn-preds.o insn-recog.o in
ranlib  libbackend.a
if [ -f ../stage_final ] \
   && cmp -s ../stage_current ../stage_final; then \
  cp ../prev-gcc/cc1-checksum.c cc1-checksum.c; \
else \
  build/genchecksum c/c-lang.o c-family/stub-objc.o attribs.o c/c-errors.o c/c-decl.o c/c-typeck.o c/c-convert.o c/c-aux-info.o c/c-objc-common.o c/c-parser.o c/c-fold.o c/gimple-parser.o c-family/c-common.o c-family/c-cp
                     checksum-options > cc1-checksum.c.tmp &&            \
  ../../src_gcc/gcc/../move-if-change cc1-checksum.c.tmp cc1-checksum.c; \
fi
if [ -f ../stage_final ] \
   && cmp -s ../stage_current ../stage_final; then \
   cp ../prev-gcc/cc1plus-checksum.c cc1plus-checksum.c; \
else \
  build/genchecksum cp/cp-lang.o c-family/stub-objc.o cp/call.o cp/class.o cp/constexpr.o cp/constraint.o cp/cp-gimplify.o cp/cp-objcp-common.o cp/cp-ubsan.o cp/cvt.o cp/cxx-pretty-print.o cp/decl.o cp/decl2.o cp/dump.o c
                     checksum-options > cc1plus-checksum.c.tmp &&          \
  ../../src_gcc/gcc/../move-if-change cc1plus-checksum.c.tmp cc1plus-checksum.c; \
fi
clang++ -fbracket-depth=512 -no-pie   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-strict-aliasing -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing
        lto/lto-lang.o lto/lto.o lto/lto-object.o attribs.o lto/lto-partition.o lto/lto-symtab.o libbackend.a main.o libcommon-target.a libcommon.a ../libcpp/libcpp.a ../libdecnumber/libdecnumber.a -L/private/tmp/musl-cro
clang: warning: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]
Undefined symbols for architecture arm64:
  "_host_hooks", referenced from:
      gt_pch_save(__sFILE*) in libbackend.a(ggc-common.o)
      gt_pch_restore(__sFILE*) in libbackend.a(ggc-common.o)
      toplev::main(int, char**) in libbackend.a(toplev.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [../../src_gcc/gcc/lto/Make-lang.in:81: lto1] Error 1
gmake[3]: *** Waiting for unfinished jobs....
rm gcc.pod
gmake[3]: Leaving directory '/private/tmp/musl-cross-20210401-11588-1t8t1uc/musl-cross-make-0.9.9/build/local/x86_64-linux-musl/obj_gcc/gcc'
gmake[2]: *** [Makefile:4361: all-gcc] Error 2
gmake[2]: Leaving directory '/private/tmp/musl-cross-20210401-11588-1t8t1uc/musl-cross-make-0.9.9/build/local/x86_64-linux-musl/obj_gcc'
gmake[1]: *** [Makefile:222: obj_gcc/gcc/.lc_built] Error 2
gmake[1]: Leaving directory '/private/tmp/musl-cross-20210401-11588-1t8t1uc/musl-cross-make-0.9.9/build/local/x86_64-linux-musl'
gmake: *** [Makefile:183: install] Error 2```

[walles]

This works for me now, thanks @xeago!

If you want to make release.sh work on M1 macs, make another PR for that!

I would welcome it, but I don't have one myself so I won't do it myself.

[walles]

M1 release out!

https://github.com/walles/riff/releases/tag/2.9