Refactoring pipeline and engine #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
takahi-i
commented
Mar 26, 2015
takahi-i
commented
- created pipline.Resources
- moved reporters and channels to Resorces
- created pipline.Resources - moved reporters and channels to Resorces
takahi-i
changed the title
| @@ -33,14 +33,14 @@ func getStageTypeModuleName(stageType string) string { | |||
| return strings.ToLower(stageType) | |||
| } | |||
|
|
|||
| func Parse(configData *map[interface{}]interface{}) (*pipelines.Pipeline, error) { | |||
| func Parse(configData *map[interface{}]interface{}) (*pipelines.Resources, error) { | |||
| envs := NewEnvVariables() | |||
| return ParseWithSpecifiedEnvs(configData, envs) | |||
| } | |||
|
|
|||
| // TODO: need refactoring | |||
There was a problem hiding this comment.
Did you finished refactoring?
If you didn't , please add comment what do you refactor about.
There was a problem hiding this comment.
Thank you for the comment. I have not done refactoring of parser.go in this commit. I will add the following comment.
TODO: make parser a struct (for simplifying redundant methods and reducing the number of function parameters)
|
LGTM |
ainoya
added a commit
that referenced
this pull request
Mar 30, 2015
Refactoring pipeline and engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.