Migration zh-hant from v1 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DingWeizhe
force-pushed
the
migration-zh-hant-from-v1
branch
from
ff5da72
to
9cd6001
Compare
DingWeizhe
force-pushed
the
migration-zh-hant-from-v1
branch
from
9cd6001
to
2d76b59
Compare
|
I have temporarily released the new package https://www.npmjs.com/package/chrono-node-v2-zh-preview |
|
@DingWeizhe I'm very sorry for my slow reply. |
|
Your change looks good to me. The only comment/concern I have is I'm not sure if I'm merging your change, but let me do some research about what is the common pattern for that first before publishing this. |
|
Also. Happy Christmas! btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ZH-Hant from v1