wip using the lite objects query

wandb · Sep 19, 2024 · df53d89 · df53d89
1 parent 1c3c013
commit df53d89
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/ObjectVersionsPage.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/ObjectVersionsPage.tsx
@@ -130,7 +130,9 @@ export const FilterableObjectVersionsTable: React.FC<{
         ? [effectiveFilter.objectName]
         : undefined,
       latestOnly: effectivelyLatestOnly,
-    }
+    },
+    undefined,
+    []
   );
 
   if (filteredObjectVersions.loading) {
@@ -394,7 +396,8 @@ const PeerVersionsLink: React.FC<{obj: ObjectVersionSchema}> = props => {
     {
       objectIds: [obj.objectId],
     },
-    100
+    100,
+    []
   );
   if (objectVersionsNode.loading) {
     return <LoadingDots />;
@@ -408,7 +411,7 @@ const PeerVersionsLink: React.FC<{obj: ObjectVersionSchema}> = props => {
         objectName: obj.objectId,
       }}
       versionCount={Math.min(countValue, 99)}
-      countIsLimited={countValue === 100}
+      countIsLimited={countValue >= 100}
       neverPeek
       variant="secondary"
     />

diff --git a/...rc/components/PagePanelComponents/Home/Browse3/pages/wfReactInterface/tsDataModelHooks.ts b/...rc/components/PagePanelComponents/Home/Browse3/pages/wfReactInterface/tsDataModelHooks.ts
@@ -910,6 +910,7 @@ const useRootObjectVersions = makeTraceServerEndpointHook(
     project: string,
     filter: ObjectVersionFilter,
     limit?: number,
+    columns?: string[],
     opts?: {skip?: boolean}
   ) => ({
     params: {
@@ -920,6 +921,8 @@ const useRootObjectVersions = makeTraceServerEndpointHook(
         latest_only: filter.latestOnly,
         is_op: false,
       },
+      limit,
+      columns,
     },
     skip: opts?.skip,
   }),
@@ -929,6 +932,7 @@ const useRootObjectVersions = makeTraceServerEndpointHook(
     inputProject,
     filter,
     limit,
+    columns,
     opts
   ): ObjectVersionSchema[] =>
     res.objs.map(convertTraceServerObjectVersionToSchema)

diff --git a/...ents/PagePanelComponents/Home/Browse3/pages/wfReactInterface/wfDataModelHooksInterface.ts b/...ents/PagePanelComponents/Home/Browse3/pages/wfReactInterface/wfDataModelHooksInterface.ts
@@ -221,6 +221,7 @@ export type WFDataModelHooksInterface = {
     project: string,
     filter: ObjectVersionFilter,
     limit?: number,
+    columns?: string[],
     opts?: {skip?: boolean}
   ) => LoadableWithError<ObjectVersionSchema[]>;
   // `useRefsData` is in beta while we integrate Shawn's new Object DB