chore: Setup automated semver bumps #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=8949f4b7a564172e3d9a64e2e4de5de2ef9cf26f |
There was a problem hiding this comment.
Why do we have this file? Shouldn't version just be in pyproject.toml?
There was a problem hiding this comment.
This is used to have the version available at runtime
There was a problem hiding this comment.
Can't you use weave.__version__?
There was a problem hiding this comment.
weave.version IS defined by version.py:
There was a problem hiding this comment.
hmm, I was expecting something more like this:
https://stackoverflow.com/a/67097076
There was a problem hiding this comment.
This works, i would like to use it as is (:
andrewtruong
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.