chore(weave): Cleanup integrations tests and inline pydantic and dataclass objects #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f42b4a5636c83db1cd7d73d69c75a70c2bf3b250 |
andrewtruong
force-pushed
the
andrew/integrations-cleanup
branch
3 times, most recently
from
abeb011
to
6e4b8e1
Compare
tssweeney
reviewed
Aug 30, 2024
weave/integrations/groq/groq_test.py
Outdated
| ("groq.chat.completions.create", 1), | ||
| ("get_game_score", 1), | ||
| ("groq.chat.completions.create", 1), | ||
| calls_list = [_get_op_name(c.op_name) for c in calls] |
There was a problem hiding this comment.
why did you remove the flatten calls? We are not only asserting order, but also depth. Those assertions are important, but lost here
There was a problem hiding this comment.
Oh I see, I misunderstood what the index represented.
client.calls() is already flat and doesn't have that nesting atm. Should there be an option for that?
tssweeney
reviewed
Aug 30, 2024
| ("llama_index.templating", 2), | ||
| ("llama_index.llm", 2), | ||
| ("openai.chat.completions.create", 3), | ||
| "llama_index.query", |
There was a problem hiding this comment.
same here (and all other places this got dropped
andrewtruong
force-pushed
the
andrew/integrations-cleanup
branch
from
fcb9292
to
dbb4c6f
Compare
tssweeney
approved these changes
Sep 10, 2024
andrewtruong
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
client.calls()instead of lower levelclient.server.calls_query()api for tests
langchaintests still use the lower level because the ordering is different there (seems to be BF?)integration_utilities.py