Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show object name if set #2297

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Sep 3, 2024

https://wandb.atlassian.net/browse/WB-19884

Handle object name exactly the same as description, rather than always filtering out name.

Prod:
Screenshot 2024-09-03 at 1 40 05 PM

This branch:
Screenshot 2024-09-03 at 1 39 46 PM

@gtarpenning gtarpenning marked this pull request as ready for review September 3, 2024 20:39
@gtarpenning gtarpenning requested a review from a team as a code owner September 3, 2024 20:39
@circle-job-mirror
Copy link

circle-job-mirror bot commented Sep 3, 2024

@gtarpenning gtarpenning changed the title chore(weave): show object name if set chore: show object name if set Sep 6, 2024
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the table as well?

@gtarpenning gtarpenning enabled auto-merge (squash) September 6, 2024 22:51
@gtarpenning gtarpenning merged commit b877255 into master Sep 6, 2024
25 checks passed
@gtarpenning gtarpenning deleted the griffin/show-name-if-set branch September 6, 2024 23:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants