chore(weave): add regex highlighting method for panel search #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a4c53fafeb68b6eda5f4a7800eb53246fbaf9a84 |
bcsherma
force-pushed
the
regex-highlight-helper
branch
from
15ca2b7
to
0e86a81
Compare
connieelee
approved these changes
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use conventional commits in your PR title. If you are unsure what conventional commits are or how to use them, please check out this notion doc.
JIRA Issue(s)
Description
This PR introduces a helper for highlighting regex matches within a string. This is an alternative to the fuzzy match that is currently implemented and will be used for section and panel names when the user searches panels with a regex.
The consumers of this new function are introduced in https://github.com/wandb/core/pull/23675
Questions
Please answer the following as appropriate, leave blank if no. If you aren't sure, ask someone!