Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete button now accounts for call/evaluation #2328

Merged
merged 2 commits into from
Sep 6, 2024
Merged

chore: delete button now accounts for call/evaluation #2328

merged 2 commits into from
Sep 6, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Sep 6, 2024 •
edited
Loading

This pr:

  • Adds parameter to specify text "call" or "evaluation" depending on the call span name
    • also handles the case of both, and both plural
  • Removes the button disable when non-critical queries are loading

Prod:
Screenshot 2024-09-06 at 1 21 10 PM

This branch:

Screenshot 2024-09-06 at 1 18 14 PM Screenshot 2024-09-06 at 1 18 22 PM Screenshot 2024-09-06 at 1 18 27 PM Screenshot 2024-09-06 at 1 18 33 PM Screenshot 2024-09-06 at 1 20 27 PM

@circle-job-mirror
Copy link

circle-job-mirror bot commented Sep 6, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2b7ac103056aa3fc53838b0edc42b2760ba1debb

@gtarpenning gtarpenning marked this pull request as ready for review September 6, 2024 20:39
@gtarpenning gtarpenning requested a review from a team as a code owner September 6, 2024 20:39
@gtarpenning gtarpenning merged commit a1067ea into master Sep 6, 2024
25 checks passed
@gtarpenning gtarpenning deleted the griffin/delete-button-text-tweaks branch September 6, 2024 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamie-rasmussen jamie-rasmussen jamie-rasmussen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtarpenning @jamie-rasmussen