Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide derived fields from trace table #2339

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Sep 10, 2024

The weave summary derived fields should be used to create nice fields in the UI, but only once the SDK has been released. summary.weave should always be safe to hide.

Also change the field names because they now conflict (in a weird and degenerate way) with the derived fields.

Prod:
Screenshot 2024-09-10 at 9 14 08 AM

Degenerate case (with horizontal scrolling):
Screenshot 2024-09-10 at 8 40 33 AM

Branch:
Screenshot 2024-09-10 at 9 14 36 AM

@gtarpenning gtarpenning marked this pull request as ready for review September 10, 2024 15:49
@gtarpenning gtarpenning requested a review from a team as a code owner September 10, 2024 15:49
@circle-job-mirror
Copy link

circle-job-mirror bot commented Sep 10, 2024

@gtarpenning gtarpenning merged commit c16f29a into master Sep 10, 2024
27 checks passed
@gtarpenning gtarpenning deleted the griffin/hide-derived-fields-in-ui branch September 10, 2024 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants