perf: use objs_query param metadata_only to get objects without their values
#2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtarpenning
changed the title
val_dump selection in objs query
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=1715e6f34d4d921e2f22495c18e1b4133f5ad701 |
tssweeney
reviewed
Sep 19, 2024
gtarpenning
changed the title
val_dump selection in objs queryval selection in objs query
gtarpenning
changed the title
val selection in objs querymetadata_only to get objects without their values
gtarpenning
force-pushed
the
griffin/object-query-lite
branch
from
6d2061b
to
c8862de
Compare
tssweeney
reviewed
Sep 24, 2024
| WHERE deleted_at IS NULL AND project_id = ? AND {pred}""" | ||
| val_dump_part = "'{}' as val_dump" if metadata_only else "val_dump" | ||
| query = f""" | ||
| SELECT |
tssweeney
approved these changes
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://wandb.atlassian.net/browse/WB-21042
Pass in
metadata_onlyto not load the val_dump. has a pretty mega impact on theobjs/querythat we use in theopsandobjectspage. That query currently barely completes in the worst projects, example below:Prod:
minutes (and crashes) on large objects
This change:
Testing
How was this PR tested?