Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x support #27

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Laravel 9.x support #27

merged 2 commits into from
Mar 7, 2022

Conversation

sylfel
Copy link

@sylfel sylfel commented Feb 28, 2022

Laravel 9.x support and php constraint >= 8.0 like in romans library

@wandersonwhcr
Copy link
Owner

@sylfel ty

I will update dependencies and try to integrate your PR.

@wandersonwhcr
Copy link
Owner

@sylfel can you check if my changes are the same that you sent before?

Also, you will need to update your dependency to use version ^3.0.

@sylfel
Copy link
Author

sylfel commented Mar 7, 2022

Hi @wandersonwhcr !
No my changes are different, and your change don't work with laravel 9

illuminate-romans require illuminate/support ^8.35 or Laravel 9.x provide illuminate/support 9.x

All your last change are good, and for perfectly

@wandersonwhcr wandersonwhcr merged commit 4304377 into wandersonwhcr:main Mar 7, 2022
@wandersonwhcr
Copy link
Owner

@sylfel merged!

ty 🥳

@wandersonwhcr
Copy link
Owner

https://github.com/wandersonwhcr/illuminate-romans/releases/tag/v3.0.0

Please, make sure you are using wandersonwhcr/illuminate-romans: ^3.0 into your package.json.

Happy Coding!

@sylfel
Copy link
Author

sylfel commented Mar 7, 2022

ty @wandersonwhcr !
It work perfectly

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants