Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Improve docker image build process and add some details #1586

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[Refactor] Improve docker image build process and add some details #1586

merged 2 commits into from
Oct 18, 2024

Conversation

zgjja
Copy link
Contributor

@zgjja zgjja commented Oct 15, 2024

  1. Delete the third party image source and use the NVIDIA's official image to build the runtime environment
  2. Add detailed document
  3. Add docker-compose support
  4. Improve .gitignore and .pre-commit-config.yaml
  5. Add cmake-format config

wang-xinyu
wang-xinyu reviewed Oct 17, 2024
View reviewed changes
docker/README Outdated Show resolved Hide resolved
docker/README Outdated Show resolved Hide resolved
docker/x86_64.dockerfile Outdated Show resolved Hide resolved
@wang-xinyu wang-xinyu merged commit 2050e3a into wang-xinyu:master Oct 18, 2024
1 check passed
@wang-xinyu
Copy link
Owner

@zgjja LGTM. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wang-xinyu wang-xinyu wang-xinyu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zgjja @wang-xinyu