Revert "feat: exclude remote model for admin UI (opensearch-project#225…

…)" This reverts commit ba01d34.
wanglam · Aug 2, 2023 · 049ab05 · 049ab05
1 parent 02e80a9
commit 049ab05
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 23 deletions.
diff --git a/public/apis/model.ts b/public/apis/model.ts
@@ -30,7 +30,6 @@ export class Model {
     size: number;
     states?: MODEL_STATE[];
     nameOrId?: string;
-    exclude?: 'REMOTE_MODEL';
   }) {
     return InnerHttpProvider.getHttp().get<ModelSearchResponse>(MODEL_API_ENDPOINT, {
       query,

diff --git a/public/components/monitoring/use_monitoring.ts b/public/components/monitoring/use_monitoring.ts
@@ -47,7 +47,6 @@ const fetchDeployedModels = async (params: Params) => {
         ? [MODEL_STATE.loadFailed, MODEL_STATE.loaded, MODEL_STATE.partiallyLoaded]
         : states,
     sort: [`${params.sort.field}-${params.sort.direction}`],
-    exclude: 'REMOTE_MODEL',
   });
   const totalPages = Math.ceil(result.total_models / params.pageSize);
   return {

diff --git a/server/routes/model_router.ts b/server/routes/model_router.ts
@@ -42,12 +42,11 @@ export const modelRouter = (router: IRouter) => {
           ),
           states: schema.maybe(schema.oneOf([schema.arrayOf(modelStateSchema), modelStateSchema])),
           nameOrId: schema.maybe(schema.string()),
-          exclude: schema.maybe(schema.literal('REMOTE_MODEL')),
         }),
       },
     },
     async (context, request) => {
-      const { from, size, sort, states, nameOrId, exclude } = request.query;
+      const { from, size, sort, states, nameOrId } = request.query;
       try {
         const payload = await ModelService.search({
           client: context.core.opensearch.client,
@@ -56,7 +55,6 @@ export const modelRouter = (router: IRouter) => {
           sort: typeof sort === 'string' ? [sort] : sort,
           states: typeof states === 'string' ? [states] : states,
           nameOrId,
-          exclude,
         });
         return opensearchDashboardsResponseFactory.ok({ body: payload });
       } catch (err) {

diff --git a/server/services/model_service.ts b/server/services/model_service.ts
@@ -43,7 +43,6 @@ export class ModelService {
     sort?: ModelSearchSort[];
     states?: MODEL_STATE[];
     nameOrId?: string;
-    exclude?: 'REMOTE_MODEL';
   }) {
     const {
       body: { hits },

diff --git a/server/services/utils/model.ts b/server/services/utils/model.ts
@@ -9,11 +9,9 @@ import { generateTermQuery } from './query';
 export const generateModelSearchQuery = ({
   states,
   nameOrId,
-  exclude,
 }: {
   states?: MODEL_STATE[];
   nameOrId?: string;
-  exclude?: 'REMOTE_MODEL';
 }) => ({
   bool: {
     must: [
@@ -35,21 +33,10 @@ export const generateModelSearchQuery = ({
           ]
         : []),
     ],
-    must_not: [
-      {
-        exists: {
-          field: 'chunk_number',
-        },
+    must_not: {
+      exists: {
+        field: 'chunk_number',
       },
-      ...(exclude === 'REMOTE_MODEL'
-        ? [
-            {
-              term: {
-                algorithm: 'REMOTE',
-              },
-            },
-          ]
-        : []),
-    ],
+    },
   },
 });