Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add GOARM in case GOARCH is arm. Add "v" to package name. #133

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Only add GOARM in case GOARCH is arm. Add "v" to package name. #133

merged 1 commit into from
Aug 19, 2023

Conversation

a-bali
Copy link
Contributor

@a-bali a-bali commented Aug 17, 2023

Do not add GOARM to the release package name, unless GOARCH is "arm". Insert 'v' (for version) before GOARM in the release package name.

@wangyoucao577
Copy link
Owner

What will the output looks like?

@a-bali
Copy link
Contributor Author

a-bali commented Aug 18, 2023

What will the output looks like?

You mean the filename? It won't add GOARM unless GOARCH is 'arm' and add a 'v' before the number e.g. armv5 instead of arm5.

@wangyoucao577 wangyoucao577 merged commit 02b8d0d into wangyoucao577:master Aug 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants