-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 155 plot spinor wf #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for writing uHu and uIu matrices in pw2wannier90. The original code does not take into account the case of nonzero exclude_bands.
plot spinor-valued WFs
Bug fix for writing uHu and uIu matrices
…s/wannier90 into fix_155_plot_spinor_WF Merge upstream
…ey want the phase included
giovannipizzi
approved these changes
Jan 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to broadcast variables in W90? Anyway this can come as a later PR, as if a new commit is added probably my approval is lost - but up to you!
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…_155_plot_spinor_WF Fix 155 plot spinor wf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #116 by adding functionality to plot spinor WF. It also fixes some bugs for pw2wannier90 v6.0 and adds a version for v6.2.1