Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage and Gyrotropic Tests #163

Merged
merged 12 commits into from
Feb 15, 2018

Conversation

jryates
Copy link
Member

@jryates jryates commented Jan 17, 2018

This adds hooks to use the codeconv code coverage tool. We also add various extra tests, including for the new gyrotropic module.

@codecov-io
Copy link

codecov-io commented Jan 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@8d2e47a). Click here to learn what that means.
The diff coverage is 81.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #163   +/-   ##
==========================================
  Coverage           ?   57.42%           
==========================================
  Files              ?       27           
  Lines              ?    15538           
  Branches           ?        0           
==========================================
  Hits               ?     8922           
  Misses             ?     6616           
  Partials           ?        0
Impacted Files Coverage Δ
src/io.F90 68.6% <ø> (ø)
src/utility.F90 63.63% <100%> (ø)
src/postw90/gyrotropic.F90 85.25% <80.82%> (ø)
src/parameters.F90 77.7% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2e47a...7a0e198. Read the comment docs.

@giovannipizzi
Copy link
Member

Two quick comments
There is this message in travis:

--------------------------------------------------------------------------
[[9679,1],0]: A high-performance Open MPI point-to-point messaging module
was unable to find any relevant network interfaces:
Module: OpenFabrics (openib)
  Host: travis-job-wannier-develo-wannier90-341781176.travisci.net
Another transport will be used instead, although this may result in
lower performance.
--------------------------------------------------------------------------

(was there also before) - any idea on how to fix this (or if it is really a problem)?

And most importantly - the time for tests is now over 20 minutes, that makes the development process a bit slow especially since one has to run the tests, wait for them to complete before merging and going to the next PR. Do you think it would be possible to speed up the parallel tests somehow?

@jryates
Copy link
Member Author

jryates commented Feb 15, 2018

Apparently this is openmpi looking for an Infiband interface, and falling back to ethernet when it doesn't find one. passing -mca btl ^openib to mpirun is supposed to solve it.

The parallel test are supposed to be quite fast. I'll have a look to see what the issue is.

@jryates jryates merged commit 6507313 into wannier-developers:develop Feb 15, 2018
@jryates jryates deleted the code_coverage branch February 15, 2018 17:24
@giovannipizzi giovannipizzi mentioned this pull request May 11, 2018
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants