-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage and Gyrotropic Tests #163
Conversation
…er90 into code_coverage Merge from upstream
Codecov Report
@@ Coverage Diff @@
## develop #163 +/- ##
==========================================
Coverage ? 57.42%
==========================================
Files ? 27
Lines ? 15538
Branches ? 0
==========================================
Hits ? 8922
Misses ? 6616
Partials ? 0
Continue to review full report at Codecov.
|
Two quick comments
(was there also before) - any idea on how to fix this (or if it is really a problem)? And most importantly - the time for tests is now over 20 minutes, that makes the development process a bit slow especially since one has to run the tests, wait for them to complete before merging and going to the next PR. Do you think it would be possible to speed up the parallel tests somehow? |
Apparently this is openmpi looking for an Infiband interface, and falling back to ethernet when it doesn't find one. passing -mca btl ^openib to mpirun is supposed to solve it. The parallel test are supposed to be quite fast. I'll have a look to see what the issue is. |
Code coverage and Gyrotropic Tests
This adds hooks to use the codeconv code coverage tool. We also add various extra tests, including for the new gyrotropic module.