Fix U matrices not being written #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were used to decide hether to enter the plotting routines. This was causing the `write_u_matrices` to be ignored if there wasn't also another plotting flag active. Now the routine is always called, and inside it there were already the appropriate if statements. This new design should be more future-proof when more plotting modes are added. I only put the header printing within an if, this is in the same file so easier to notice in the future, and anyway even if forgotten will just not print the header. This commit fixes wannier-developers#139
and the size of the U matrices is correct.
Codecov Report
@@ Coverage Diff @@
## develop #177 +/- ##
===========================================
+ Coverage 57.57% 57.66% +0.08%
===========================================
Files 27 27
Lines 15624 15624
===========================================
+ Hits 8995 9009 +14
+ Misses 6629 6615 -14
Continue to review full report at Codecov.
|
|
Looks good. |
|
Hi @mostofi, you closed instead of merging. I'll reopen it - you need to approve it and then merge it. |
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…plotting_u_matrices Fix U matrices not being written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #139 by removing the unneeded checks in wannier_prog for plotting.
These were used to decide hether to enter the plotting routines.
This was causing the
write_u_matricesto be ignored if there wasn't also another plotting flag active.I'm also adding a test to check that the
_u.matis actually being generated, and that at least the matrix shape is correct.