Shift current #181
Merged
Shift current #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pilation tests because of them. Hopefully fixed now.
…ravis testing procedure. Modified shift-current test in the test-suite example, it was too time-consuming, lowered number of k points.
Codecov Report
@@ Coverage Diff @@
## shift-current #181 +/- ##
================================================
Coverage ? 57.95%
================================================
Files ? 27
Lines ? 16031
Branches ? 0
================================================
Hits ? 9290
Misses ? 6741
Partials ? 0
Continue to review full report at Codecov.
|
|
Hi! I merged this, but this PR, though, was just a PR with a couple of fixes (long lines) on top of the branch 'shift-current' that has the modifications. That one is not merged yet - I will reopen #180 to discuss the actual changes (or, better, you should open a new PR from your branch, but directly to merge on 'develop'). |
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced option for calculating nonlinear shift current as a new berry_task=sc,
following the structure of the linear optical conductivity (berry_task=kubo).
The code implements the formalism given in J. Ibañez-Azpiroz, S. S. Tsirkin and I. Souza, arXiv:1804.04030 (2018).
Included additional material: description of new parameters in the user guide, example25, description and running steps for example25, test example in testsuite.