Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic library compilation #188

Merged
merged 2 commits into from
Jun 23, 2018
Merged

Add support for dynamic library compilation #188

merged 2 commits into from
Jun 23, 2018

Conversation

giovannipizzi
Copy link
Member

Fixes #143

@codecov
Copy link

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #188 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #188   +/-   ##
========================================
  Coverage    57.99%   57.99%           
========================================
  Files           27       27           
  Lines        16052    16052           
========================================
  Hits          9310     9310           
  Misses        6742     6742

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc32b5...d6915d1. Read the comment docs.

jryates
jryates approved these changes Jun 23, 2018
View reviewed changes
Copy link
Member

@jryates jryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok for me on OSX / gfortran

@giovannipizzi giovannipizzi merged commit c3ecf36 into wannier-developers:develop Jun 23, 2018
@giovannipizzi giovannipizzi deleted the fix_143_dynlib branch June 23, 2018 14:30
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
@giovannipizzi
Merge pull request wannier-developers#188 from giovannipizzi/fix_143_…
5c2e8e7 
…dynlib

Add support for dynamic library compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryates jryates jryates approved these changes

@VVitale VVitale Awaiting requested review from VVitale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannipizzi @jryates